Skip to content

Conversation

@gregfromstl
Copy link
Contributor

@gregfromstl gregfromstl commented May 6, 2025


PR-Codex overview

This PR focuses on enhancing the checkout experience by introducing new components and improving the handling of analytics and payment functionalities within the checkout section of the dashboard.

Detailed summary

  • Removed a redirect from /checkout to /connect.
  • Added THIRDWEB_ANALYTICS_DOMAIN to urls.ts.
  • Introduced Providers component to wrap children in ThirdwebProvider.
  • Created CheckoutLayout with ThemeProvider and Providers.
  • Enhanced CheckoutEmbed with analytics and payment handling.
  • Implemented error handling for required parameters in RoutesPage.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@gregfromstl gregfromstl requested review from a team as code owners May 6, 2025 04:32
@linear
Copy link

linear bot commented May 6, 2025

@changeset-bot
Copy link

changeset-bot bot commented May 6, 2025

⚠️ No Changeset found

Latest commit: f2b4fe6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented May 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2025 6:42am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) May 6, 2025 6:42am
login ⬜️ Skipped (Inspect) May 6, 2025 6:42am
thirdweb_playground ⬜️ Skipped (Inspect) May 6, 2025 6:42am
wallet-ui ⬜️ Skipped (Inspect) May 6, 2025 6:42am

@graphite-app
Copy link
Contributor

graphite-app bot commented May 6, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label May 6, 2025
@codecov
Copy link

codecov bot commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.03%. Comparing base (6dd2b09) to head (f2b4fe6).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6954   +/-   ##
=======================================
  Coverage   55.03%   55.03%           
=======================================
  Files         897      897           
  Lines       57327    57327           
  Branches     3964     3964           
=======================================
  Hits        31551    31551           
  Misses      25680    25680           
  Partials       96       96           
Flag Coverage Δ
packages 55.03% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 50.96 KB (0%) 1.1 s (0%) 168 ms (+180.28% 🔺) 1.2 s
thirdweb (cjs) 143.17 KB (0%) 2.9 s (0%) 307 ms (+76.96% 🔺) 3.2 s
thirdweb (minimal + tree-shaking) 5.67 KB (0%) 114 ms (0%) 75 ms (+1305.14% 🔺) 189 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 31 ms (+1262.62% 🔺) 41 ms
thirdweb/react (minimal + tree-shaking) 19.47 KB (0%) 390 ms (0%) 89 ms (+684.26% 🔺) 478 ms

@gregfromstl gregfromstl force-pushed the greg/tool-4388-checkout-link-page branch from 51871d6 to 5222ff1 Compare May 6, 2025 04:39
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 6, 2025 04:39 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 6, 2025 04:39 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 6, 2025 04:39 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 6, 2025 04:39 Inactive
@gregfromstl gregfromstl force-pushed the greg/tool-4388-checkout-link-page branch from 5222ff1 to 849ff2c Compare May 6, 2025 04:43
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 6, 2025 04:43 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 6, 2025 04:43 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 6, 2025 04:43 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 6, 2025 04:43 Inactive
@gregfromstl gregfromstl force-pushed the greg/tool-4388-checkout-link-page branch from 849ff2c to 4c54110 Compare May 6, 2025 04:44
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 6, 2025 04:44 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 6, 2025 04:44 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 6, 2025 04:44 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 6, 2025 04:44 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 6, 2025 05:26 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 6, 2025 05:26 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 6, 2025 05:26 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 6, 2025 05:26 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 6, 2025 06:26 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 6, 2025 06:26 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 6, 2025 06:26 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 6, 2025 06:26 Inactive
@gregfromstl gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label May 6, 2025
Copy link
Contributor Author

gregfromstl commented May 6, 2025

Merge activity

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on enhancing the checkout experience in the `dashboard` app by integrating analytics and improving the layout and structure of the checkout components.

### Detailed summary
- Removed a redirect from `"/checkout"` to `"/connect"` in `apps/dashboard/redirects.js`.
- Added `THIRDWEB_ANALYTICS_DOMAIN` to `urls.ts`.
- Created `Providers` component to wrap children with `ThirdwebProvider`.
- Enhanced `CheckoutLayout` with `ThemeProvider` and layout structure.
- Updated `CheckoutEmbed` to utilize new analytics domain and handle payment success.
- Implemented a new `RoutesPage` for handling checkout logic and parameters.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@graphite-app graphite-app bot force-pushed the greg/tool-4388-checkout-link-page branch from 0647ff0 to f2b4fe6 Compare May 6, 2025 06:36
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 6, 2025 06:36 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 6, 2025 06:36 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 6, 2025 06:36 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 6, 2025 06:36 Inactive
@graphite-app graphite-app bot merged commit f2b4fe6 into main May 6, 2025
23 checks passed
@graphite-app graphite-app bot deleted the greg/tool-4388-checkout-link-page branch May 6, 2025 06:43
@graphite-app graphite-app bot removed the merge-queue Adds the pull request to Graphite's merge queue. label May 6, 2025
@vercel vercel bot temporarily deployed to Production – docs-v2 May 6, 2025 06:43 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground May 6, 2025 06:43 Inactive
@vercel vercel bot temporarily deployed to Production – login May 6, 2025 06:43 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui May 6, 2025 06:43 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants